Page MenuHomePhabricator

JavaScriptTag
ActivePublic

Members (9)

Watchers (11)

Details

Description

Tasks related to JavaScript in MediaWiki core or extensions.

See also Instrument-ClientError (Javascript error logging in Wikimedia production).

Recent Activity

Today

Jdlrobson added a comment to T350840: TypeError: Cannot read properties of null (reading 'parentNode') at ThreadItem.js.ThreadItem.static.newFromJSON.

I can replicate on https://bn.m.wikivoyage.org/wiki/%E0%A6%89%E0%A6%87%E0%A6%95%E0%A6%BF%E0%A6%AD%E0%A7%8D%E0%A6%B0%E0%A6%AE%E0%A6%A3:%E0%A6%A8%E0%A6%BF%E0%A6%AC%E0%A6%A8%E0%A7%8D%E0%A6%A7_%E0%A6%AA%E0%A7%8D%E0%A6%B0%E0%A6%A4%E0%A6%BF%E0%A6%AF%E0%A7%8B%E0%A6%97%E0%A6%BF%E0%A6%A4%E0%A6%BE_%E0%A7%A8%E0%A7%A6%E0%A7%A8%E0%A7%AA/%E0%A6%A8%E0%A6%BF%E0%A6%AC%E0%A6%A8%E0%A7%8D%E0%A6%A7_%E0%A6%A4%E0%A6%BE%E0%A6%B2%E0%A6%BF%E0%A6%95%E0%A6%BE - I can look into the associated gadget later and suggest a fix.

Thu, Oct 24, 4:28 PMLocal-Wiki-Template-And-Gadget-Issues, JavaScript, Wikimedia-production-error, DiscussionTools
Jdlrobson reopened T350840: TypeError: Cannot read properties of null (reading 'parentNode') at ThreadItem.js.ThreadItem.static.newFromJSON as "Open".

This is still occurring at a significant rante - mostly on bn.m.wikivoyage.org and en.m.wikivoyage.org
so I assume a gadget there also needs to be updated.

Thu, Oct 24, 4:28 PMLocal-Wiki-Template-And-Gadget-Issues, JavaScript, Wikimedia-production-error, DiscussionTools
hashar closed T184657: Generate JavaScript code coverage reports for extensions as Declined.

We did it for PHPUnit tests as reflected on https://doc.wikimedia.org/cover-extensions/ .

Thu, Oct 24, 2:28 PM · Code-Health, Test-Coverage, JavaScript, Continuous-Integration-Infrastructure
hashar closed T116808: Provide a CI job to generate JS code coverage reports for extensions by using karma-coverage instead of just karma, a subtask of T184657: Generate JavaScript code coverage reports for extensions, as Declined.
Thu, Oct 24, 2:20 PM · Code-Health, Test-Coverage, JavaScript, Continuous-Integration-Infrastructure

Tue, Oct 22

Maintenance_bot edited projects for T40932: Feature to copy or download code blocks, added: User-notice-archive; removed User-notice.
Tue, Oct 22, 5:31 PM · User-notice-archive, MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), JavaScript, SyntaxHighlight

Sat, Oct 19

matmarex closed T375132: Simplify code to avoid interpreting "$" characters in string replacement as Resolved.
Sat, Oct 19, 12:33 AM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), MediaWiki-Internationalization, JavaScript
Maintenance_bot removed a project from T375132: Simplify code to avoid interpreting "$" characters in string replacement: Patch-For-Review.
Sat, Oct 19, 12:30 AM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), MediaWiki-Internationalization, JavaScript
ReleaseTaggerBot added a project to T375132: Simplify code to avoid interpreting "$" characters in string replacement: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).
Sat, Oct 19, 12:00 AM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), MediaWiki-Internationalization, JavaScript

Fri, Oct 18

gerritbot added a comment to T375132: Simplify code to avoid interpreting "$" characters in string replacement.

Change #1081448 merged by jenkins-bot:

[mediawiki/core@master] Simplify code to avoid interpreting "$" characters in string replacement

https://gerrit.wikimedia.org/r/1081448

Fri, Oct 18, 11:47 PM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), MediaWiki-Internationalization, JavaScript
Od1n added a comment to T375132: Simplify code to avoid interpreting "$" characters in string replacement.

I took the opportunity to replace the other occurrence in mediawiki/core.

Fri, Oct 18, 10:21 PM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), MediaWiki-Internationalization, JavaScript
matmarex added a comment to T375132: Simplify code to avoid interpreting "$" characters in string replacement.

That's neat, I like it.

Fri, Oct 18, 10:04 PM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), MediaWiki-Internationalization, JavaScript
gerritbot added a project to T375132: Simplify code to avoid interpreting "$" characters in string replacement: Patch-For-Review.
Fri, Oct 18, 9:21 PM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), MediaWiki-Internationalization, JavaScript
gerritbot added a comment to T375132: Simplify code to avoid interpreting "$" characters in string replacement.

Change #1081448 had a related patch set uploaded (by Gerrit Patch Uploader; author: Anne Haunime):

[mediawiki/core@master] Simplify code to avoid interpreting "$" characters in string replacement

https://gerrit.wikimedia.org/r/1081448

Fri, Oct 18, 9:21 PM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), MediaWiki-Internationalization, JavaScript
ReleaseTaggerBot added a project to T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).
Fri, Oct 18, 1:00 AM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing
Maintenance_bot removed a project from T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page: Patch-For-Review.
Fri, Oct 18, 12:30 AM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing
matmarex closed T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page as Resolved.
Fri, Oct 18, 12:16 AM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing
gerritbot added a comment to T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page.

Change #1080320 merged by jenkins-bot:

[mediawiki/core@master] live preview: Do not add edit/view-source link for special pages

https://gerrit.wikimedia.org/r/1080320

Fri, Oct 18, 12:14 AM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing
gerritbot added a comment to T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page.

Change #1080323 merged by jenkins-bot:

[mediawiki/core@master] TemplatesOnThisPage: Do not show non-functional link for special pages

https://gerrit.wikimedia.org/r/1080323

Fri, Oct 18, 12:14 AM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing

Thu, Oct 17

matmarex added a comment to T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page.

I couldn't reproduce this at first – special page transclusion does not result in those links being shown. I eventually figured out that the links are produced by Scribunto's mw.title getContent() method. I think that's the real bug here, and I filed a task about it: T377530: Scribunto mw.title getContent() method can record templatelinks to special pages (but I still approved your patches here, as it seems reasonable to handle this case – maybe recording special page transclusions is made to work one day, or maybe no one ever fixes that Scribunto bug).

Thu, Oct 17, 11:55 PM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing

Wed, Oct 16

Ebrahim added a comment to T374314: Consider use of native URL API instead of mw.Uri.

Thanks Od1n, very appreciated, I should do that for my local wiki also sometime. There are still some remaining extensions and I've got busy with some other things but overall this went well I think. Thanks

Wed, Oct 16, 8:41 PM · MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Patch-For-Review, Technical-Debt, JavaScript, MediaWiki-General
Krinkle updated the task description for T277675: Add native support for ES2016-ES2020 or higher versions.
Wed, Oct 16, 7:43 PM · MediaWiki-Platform-Team, Wikimedia-Minify, JavaScript, MediaWiki-ResourceLoader
Maintenance_bot removed a project from T376953: Fix jsdoc for Kartographer to allow update to newer jsdoc-wmf-theme: Patch-For-Review.
Wed, Oct 16, 5:30 PM · JavaScript, JSDoc WMF theme, Maps (Kartographer)
gerritbot added a comment to T376953: Fix jsdoc for Kartographer to allow update to newer jsdoc-wmf-theme.

Change #1069544 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] build: Updating npm dependencies

https://gerrit.wikimedia.org/r/1069544

Wed, Oct 16, 5:01 PMJavaScript, JSDoc WMF theme, Maps (Kartographer)
TheDJ moved T342040: TypeError: undefined is not an object (evaluating 'src[src.length-1].res') from To sort to Backlog/maint on the TimedMediaHandler board.
Wed, Oct 16, 1:54 PMJavaScript, Unstewarded-production-error, TimedMediaHandler, Wikimedia-production-error
Od1n added a comment to T374314: Consider use of native URL API instead of mw.Uri.

I have removed all uses on frwiki (I handled the remaining cases I mentioned above) and on frwiktionary (there was only one occurrence).

Wed, Oct 16, 1:53 PMMW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Patch-For-Review, Technical-Debt, JavaScript, MediaWiki-General

Tue, Oct 15

gerritbot added a comment to T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page.

Change #1080323 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] TemplatesOnThisPage: Do not show non-functional link for special pages

https://gerrit.wikimedia.org/r/1080323

Tue, Oct 15, 4:40 PMMW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing
Ammarpad added a comment to T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page.

I think we also need to duplicate this for the non-live preview version. There's no error in that case, but a non-functional 'view-soure' link is always shown.

Tue, Oct 15, 4:33 PMMW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing
gerritbot added a project to T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page: Patch-For-Review.
Tue, Oct 15, 4:21 PMMW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing
gerritbot added a comment to T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page.

Change #1080320 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] live preview: Do not add edit/view-source link for special pages

https://gerrit.wikimedia.org/r/1080320

Tue, Oct 15, 4:21 PMMW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing

Mon, Oct 14

ReleaseTaggerBot edited projects for T374314: Consider use of native URL API instead of mw.Uri, added: MW-1.43-notes (1.43.0-wmf.27; 2024-10-15); removed MW-1.43-notes (1.43.0-wmf.26; 2024-10-08).
Mon, Oct 14, 4:00 PMMW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Patch-For-Review, Technical-Debt, JavaScript, MediaWiki-General
gerritbot added a comment to T374314: Consider use of native URL API instead of mw.Uri.

Change #1071846 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Use browser provided URL object instead of mw.Uri

https://gerrit.wikimedia.org/r/1071846

Mon, Oct 14, 3:53 PMMW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Patch-For-Review, Technical-Debt, JavaScript, MediaWiki-General

Sun, Oct 13

gerritbot added a comment to T334853: Clean up JS code now that we can use ES6 rather than ES5 across all Wikimedia deployed codebases.

Change #1074726 merged by jenkins-bot:

[mediawiki/extensions/TocTree@master] Use ES6 features

https://gerrit.wikimedia.org/r/1074726

Sun, Oct 13, 2:54 PMMW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Patch-For-Review, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Epic, JavaScript, WMF-General-or-Unknown, Code-Health

Sat, Oct 12

SD0001 added a comment to T40932: Feature to copy or download code blocks.

I see ext.pygments.view is not being loaded in Parsoid DOM, even though we are adding the module to ParserOutput via the parser hook. I guess something else needs to be done for Parsoid compatibility?

Sat, Oct 12, 5:28 PMUser-notice-archive, MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), JavaScript, SyntaxHighlight
Od1n added a comment to T374314: Consider use of native URL API instead of mw.Uri.

I have removed the majority of uses of "mw.Uri" on frwiki.

Sat, Oct 12, 2:19 PMMW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Patch-For-Review, Technical-Debt, JavaScript, MediaWiki-General

Fri, Oct 11

Maintenance_bot removed a project from T40932: Feature to copy or download code blocks: Patch-For-Review.
Fri, Oct 11, 4:31 PMUser-notice-archive, MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), JavaScript, SyntaxHighlight
ReleaseTaggerBot edited projects for T40932: Feature to copy or download code blocks, added: MW-1.43-notes (1.43.0-wmf.27; 2024-10-15); removed MW-1.43-notes (1.43.0-wmf.25; 2024-10-01).
Fri, Oct 11, 4:00 PMUser-notice-archive, MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), JavaScript, SyntaxHighlight
gerritbot added a comment to T40932: Feature to copy or download code blocks.

Change #1078975 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Fix styling for code blocks with copy buttons next to floated content

https://gerrit.wikimedia.org/r/1078975

Fri, Oct 11, 3:31 PMUser-notice-archive, MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), JavaScript, SyntaxHighlight
SD0001 updated subscribers of T40932: Feature to copy or download code blocks.
Fri, Oct 11, 3:18 PMUser-notice-archive, MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), JavaScript, SyntaxHighlight
Od1n added a comment to T374314: Consider use of native URL API instead of mw.Uri.

Ok, thanks to getAll() it can be achieved, just a very tiny bit less conveniently:

Fri, Oct 11, 2:29 PMMW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Patch-For-Review, Technical-Debt, JavaScript, MediaWiki-General
Od1n added a comment to T374314: Consider use of native URL API instead of mw.Uri.

Also, worth noting that mw.Uri and URL treat duplicate query parameters when parsing differently.

uri = new mw.Uri('http://example.com/foo?a=1&a=2')
uri.query.a // => [ "1", "2" ]
uri = new mw.Uri('http://example.com/foo?a=1&a=2', {arrayParams: true})
uri.query.a // => "2"

url = new URL('http://example.com/foo?a=1&a=2')
url.searchParams.get('a') // => "1"
url.searchParams.getAll('a') // => [ "1", "2" ]
Fri, Oct 11, 2:17 PMMW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Patch-For-Review, Technical-Debt, JavaScript, MediaWiki-General
Ammarpad changed the status of T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page from Open to In Progress.
Fri, Oct 11, 12:20 PMMW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing

Thu, Oct 10

Nardog moved T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page from Backlog to Live preview on the MediaWiki-Page-editing board.
Thu, Oct 10, 10:30 PMMW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing
Nardog renamed T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page from "TypeError: template.apiData.actions is undefined" when live-previewing page that transcludes a special page to "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page.
Thu, Oct 10, 10:30 PMMW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing
Nardog created T376964: "TypeError: template.apiData.actions is undefined" when live-previewing a page that transcludes a special page.
Thu, Oct 10, 10:30 PMMW-1.43-notes (1.43.0-wmf.28; 2024-10-22), JavaScript, Wikimedia-production-error, Realtime Preview, MediaWiki-Page-editing
gerritbot added a project to T376953: Fix jsdoc for Kartographer to allow update to newer jsdoc-wmf-theme: Patch-For-Review.
Thu, Oct 10, 9:39 PMJavaScript, JSDoc WMF theme, Maps (Kartographer)
gerritbot added a comment to T376953: Fix jsdoc for Kartographer to allow update to newer jsdoc-wmf-theme.

Change #1069544 had a related patch set uploaded (by Jforrester; author: Libraryupgrader):

[mediawiki/extensions/Kartographer@master] build: Updating npm dependencies

https://gerrit.wikimedia.org/r/1069544

Thu, Oct 10, 9:39 PMJavaScript, JSDoc WMF theme, Maps (Kartographer)
Jdforrester-WMF added a comment to T376953: Fix jsdoc for Kartographer to allow update to newer jsdoc-wmf-theme.

Just slam _addItem into "allowedGlobals": [] in the jsdoc.json and it'll work fine.

Thu, Oct 10, 9:16 PMJavaScript, JSDoc WMF theme, Maps (Kartographer)
simon04 added a comment to T321532: Console error - 'Error: View mediainfoview does not exist' on Commons File pages.

Any new insights? If createEntityView in wikibase.ui.entityViewInit.js shall not be called from commonswiki, maybe we should simply return from this function if mw.config.get('wgWikiID') === 'commonswiki' && mw.config.get( 'wgCanonicalNamespace' ) === 'File'

Thu, Oct 10, 9:08 PMWikidata-UX, JavaScript, [DEPRECATED] wdwb-tech, Wikidata, SDC General, Wikimedia-production-error, WikibaseMediaInfo, Structured-Data-Backlog
Umherirrender created T376953: Fix jsdoc for Kartographer to allow update to newer jsdoc-wmf-theme.
Thu, Oct 10, 9:06 PMJavaScript, JSDoc WMF theme, Maps (Kartographer)
Quiddity moved T40932: Feature to copy or download code blocks from In current Tech/News draft to Already announced/Archive on the User-notice board.
Thu, Oct 10, 6:08 PMUser-notice-archive, MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), JavaScript, SyntaxHighlight