Switch caching package's interface to be generic and add experimental flag to try different caches #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/CLI
josephschorr
force-pushed
the
cache-improvements
branch
from
89207d9
to
58d67f2
Compare
ecordell
reviewed
Jul 22, 2024
| "github.com/rs/zerolog" | ||
| ) | ||
|
|
||
| func NewTheineCacheWithMetrics[K KeyString, V any](name string, config *Config) (Cache[K, V], error) { |
There was a problem hiding this comment.
Why not also add otter as an option so we can test side-by-side? or did you look at both and decide theine was a clear winner?
There was a problem hiding this comment.
Otter's own README shows it is less performant for DB-like services. We could always add it as a followup
There was a problem hiding this comment.
I just don't see how we'll know without testing both. Otter's benchmarks look better for everything except 100% writes
There was a problem hiding this comment.
let's add both and blog about it
josephschorr
force-pushed
the
cache-improvements
branch
2 times, most recently
from
d66e77d
to
84a622e
Compare
josephschorr
changed the title
ecordell
previously approved these changes
Jul 25, 2024
… flag to try different caches
josephschorr
force-pushed
the
cache-improvements
branch
from
84a622e
to
a90724e
Compare
ecordell
approved these changes
Jul 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1979