Extract function types from function and arrow expressions. #60234
+492
−387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
jakebailey
reviewed
Oct 15, 2024
| if (isFunctionLike(node) || isJSDocSignature(node)) { | ||
| const signature = getSignatureFromDeclaration(node); | ||
| const expandedParams = getExpandedParameters(signature, /*skipUnionExpanding*/ true)[0]; | ||
| const expandedParams = !expandParameters ? signature.parameters : getExpandedParameters(signature, /*skipUnionExpanding*/ true)[0]; |
There was a problem hiding this comment.
Believe it or not, all tests pass if we just unconditionally use signature.parameters here (not expanding at all). I'm not an expert in why we needed to expand them before, but it sure feels like we don't need to do them at all anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings TS emit closer to what an external tool could emit without type information.