fix(install): Skip optional dependencies if false in bunfig.toml #14629
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eckhardt-D
force-pushed
the
fix/optional-deps
branch
from
8efff52
to
c1250bf
Compare
Eckhardt-D
force-pushed
the
fix/optional-deps
branch
from
c1250bf
to
c8f75ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #14619
Closes #7274
Checks the optional dependency feature in
bunfig.tomlbefore creating any network tasks and installing the dependency, but still lists it as optional in the lockfile.bun-debug installwith the reproduction example in Optional dependencies cause package installations to fail�#14619