Page MenuHomePhabricator
Create Task
Maniphest T202469

jsonconfig-license-notice-license-unset showing up on non-tabular data pages
Closed, ResolvedPublic
Actions

Description

Screenshot_2018-08-21 Editing Wikibugs (section) - MediaWiki(1).png (1×2 px, 82 KB)

The message should only be shown on tabular data pages I assume.

Details

SubjectRepoBranchLines +/-
Fix license noticesmediawiki/extensions/JsonConfigwmf/1.32.0-wmf.18+52 -49
Fix license noticesmediawiki/extensions/JsonConfigmaster+52 -49
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm triaged this task as Unbreak Now! priority.Aug 21 2018, 11:57 PM
Legoktm created this task.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper. · View Herald TranscriptAug 21 2018, 11:57 PM
Legoktm updated the task description. (Show Details)Aug 21 2018, 11:58 PM
Legoktm added a parent task: T191064: 1.32.0-wmf.18 deployment blockers.
Jdforrester-WMF subscribed.Aug 22 2018, 12:01 AM
Yurik added a comment.Aug 22 2018, 12:01 AM

Introduced by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/JsonConfig/+/450397/ - looking...

gerritbot subscribed.Aug 22 2018, 12:45 AM

Change 454444 had a related patch set uploaded (by Yurik; owner: Yuri Astrakhan):
[mediawiki/extensions/JsonConfig@master] Fix license notices

https://gerrit.wikimedia.org/r/454444

gerritbot added a project: Patch-For-Review.Aug 22 2018, 12:45 AM
gerritbot added a comment.Aug 22 2018, 4:10 AM

Change 454444 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Fix license notices

https://gerrit.wikimedia.org/r/454444

• Mholloway subscribed.Aug 22 2018, 4:58 AM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 22 2018, 5:01 AM
gerritbot added a comment.Aug 22 2018, 4:51 PM

Change 454591 had a related patch set uploaded (by Jforrester; owner: Yuri Astrakhan):
[mediawiki/extensions/JsonConfig@wmf/1.32.0-wmf.18] Fix license notices

https://gerrit.wikimedia.org/r/454591

gerritbot added a comment.Aug 22 2018, 5:28 PM

Change 454591 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@wmf/1.32.0-wmf.18] Fix license notices

https://gerrit.wikimedia.org/r/454591

Stashbot subscribed.Aug 22 2018, 5:31 PM

Mentioned in SAL (#wikimedia-operations) [2018-08-22T17:31:37Z] <jforrester@deploy1001> Synchronized php-1.32.0-wmf.18/extensions/JsonConfig/includes/JCSingleton.php: T202469 fix UBN trainblocker for wmf.18 (duration: 00m 56s)

Jdforrester-WMF closed this task as Resolved.Aug 22 2018, 5:32 PM
Jdforrester-WMF assigned this task to Yurik.
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review.

Now hot-deployed to production.

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)).Aug 22 2018, 5:57 PM
Liuxinyu970226 unsubscribed.Aug 23 2018, 2:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. � Wikimedia Foundation � Privacy Policy � Code of Conduct � Terms of Use � Disclaimer � CC-BY-SA � GPL � Credits